ln is concave #990
Merged
ln is concave #990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
affeldt-aist
added
the
TODO: MC2 port
affeldt-aist
force-pushed
the
exp_20230727
branch
from
966cfef to
7caabe0
Compare
affeldt-aist
force-pushed
the
exp_20230727
branch
from
7caabe0 to
218da9b
Compare
affeldt-aist
force-pushed
the
exp_20230727
branch
from
218da9b to
8471288
Compare
zstone1
reviewed
Aug 9, 2023
| Section conv_realDomainType. | ||
| Context {R : realDomainType}. | ||
|
|
||
| Lemma conv_gt0 (a b : R^o) (t : {i01 R}) : 0 < a -> 0 < b -> 0 < a <| t |> b. |
There was a problem hiding this comment.
Should we make this an instance of PosNum?
There was a problem hiding this comment.
It looks like a good idea but I'd prefer to do it later because I may need @proux01 's help (I easily forget about signed.v). I will issue after merging.
There was a problem hiding this comment.
I guess you should take inspiration from min and max in signed.v
zstone1
approved these changes
Aug 9, 2023
CohenCyril
reviewed
Aug 11, 2023
Comment on lines
+605
to
+606
| Lemma concave_ln (t : {i01 R}) (a b : R^o) : 0 < a -> 0 < b -> | ||
| (ln a : R^o) <| t |> (ln b : R^o) <= ln (a <| t |> b). |
There was a problem hiding this comment.
@affeldt-aist why the R^o here?
There was a problem hiding this comment.
The only instances were lmodType and R^o with R : realDomainType. PR #1010 hopefully improves the situation be providing direct instances for realDomainType, realFieldType, and realType.
affeldt-aist
added a commit
to affeldt-aist/analysis
that referenced
this pull request
Aug 23, 2023
* ln is concave, conjugate/powR
proux01
removed
the
TODO: MC2 port
IshiguroYoshihiro
pushed a commit
to IshiguroYoshihiro/analysis
that referenced
this pull request
Sep 7, 2023
* ln is concave, conjugate/powR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
preliminary step for the revision of PR #942
Things done/to do
CHANGELOG_UNRELEASED.md- [ ] added corresponding documentation in the headersCompatibility with MathComp 2.0
TODO: HB portto make sure someone ports this PR tothe
hierarchy-builderbranch or I already opened an issue or PR (please cross reference).Automatic note to reviewers
Read this Checklist and put a milestone if possible.